-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Virtual Point Clouds] Add combobox to adjust the switching between rendering overview only and sub index rendering #64351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Tests failed for Qt 6 (ALL_BUT_PROVIDERS - ubuntu)One or more tests failed using the build from commit a9eb485 virtual_pointcloud_3d_overview (testPointCloud3DOverview)virtual_pointcloud_3d_overviewTest failed at testPointCloud3DOverview at tests/src/3d/testqgspointcloud3drendering.cpp:619
The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Tests failed for Qt 6 (ALL_BUT_PROVIDERS - fedora)One or more tests failed using the build from commit a9eb485 virtual_pointcloud_3d_overview (testPointCloud3DOverview)virtual_pointcloud_3d_overviewTest failed at testPointCloud3DOverview at tests/src/3d/testqgspointcloud3drendering.cpp:619
The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
slider holds values with which the sub index extent/3d bounding box is mutliplied by and depending on the map canvas containing the extent or camera being within the scaled bounding box, we render the full sub index or just the overview
8657483 to
e68fb10
Compare
rename zoomOutMultiplier to overviewSwitchingScale
This PR adds a slider that controls the point of switching between rendering overview only and rendering a sub index of the VPC.
The slider is more aggressive going to the right, less aggressive going to the left.
On 2D map canvas, if the average extent width of the sub indexes multiplied by the value from the slider is higher than the viewable map canvas, a sub index is loaded, otherwise overview only gets rendered.
Similarly, in the 3D Map, multiplier is applied on the sub index bounding box and if the camera is located within the box, sub index is fully loaded and rendered, if the camera is outside the box, overview only is rendered.
One change is that when all the sub indexes are shown in the 3D Map, we disable overview rendering to save resources.